[FFmpeg-devel] [PATCH]Fix building with --disable-everything

[Paul B Mahol]

On 2/9/13, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> Paul B Mahol <onemda <at> gmail.com> writes:
>
>> >> > Doesn't ticket #2253 contain all information?
>> >> > What else could be useful?
>> >>
>> >> Your explanation, compiled dump is not.
>> >> Also explanation in commit log.
>> >
>> > The explanation is that I would like to fix a
>> > regression.
>>
>> That is not explanation why you decided to make such
>> changes and not some other ones.
>
> I did not find any other change that fixes compilation
> with --disable-everything.
> (But I don't consider that an explanation for this
> patch. The relevant reason is that we have a
> regression in the build system that I would like
> to fix.)

But the fix you provided is hack. You just did some changes and
declare: "hey, this works lets post it on mailing list".

Fact that patch works is not enough to guarantee that it is also correct.

>
> Carl Eugen
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>