[FFmpeg-devel] [PATCH] fate/subtitles: add character encoding conversion test.

[Clément Bœsch]

On Fri, Feb 22, 2013 at 01:55:57AM +0100, Clément Bœsch wrote:
> On Wed, Feb 20, 2013 at 02:07:04PM +0100, Clément Bœsch wrote:
> > ---
> >  tests/fate/subtitles.mak   | 5 +++++
> >  tests/ref/fate/sub-charenc | 1 +
> >  2 files changed, 6 insertions(+)
> >  create mode 100644 tests/ref/fate/sub-charenc
> > 
> > diff --git a/tests/fate/subtitles.mak b/tests/fate/subtitles.mak
> > index 2c4f878..dac9bc0 100644
> > --- a/tests/fate/subtitles.mak
> > +++ b/tests/fate/subtitles.mak
> > @@ -49,6 +49,11 @@ fate-sub-vplayer: CMD = md5 -i $(SAMPLES)/sub/VPlayer_capability_tester.txt -f a
> >  FATE_SUBTITLES_ASS-$(call DEMDEC, WEBVTT, WEBVTT) += fate-sub-webvtt
> >  fate-sub-webvtt: CMD = md5 -i $(SAMPLES)/sub/WebVTT_capability_tester.vtt -f ass
> >  
> > +ifdef HAVE_ICONV
> > +FATE_SUBTITLES_ASS-$(call DEMDEC, MICRODVD, MICRODVD) += fate-sub-charenc
> > +fate-sub-charenc: CMD = md5 -sub_charenc cp1251 -i $(SAMPLES)/sub/cp1251-subtitles.sub -f ass
> > +endif
> > +
> >  FATE_SUBTITLES-$(call ENCMUX, ASS, ASS) += $(FATE_SUBTITLES_ASS-yes)
> >  FATE_SUBTITLES += $(FATE_SUBTITLES-yes)
> >  
> > diff --git a/tests/ref/fate/sub-charenc b/tests/ref/fate/sub-charenc
> > new file mode 100644
> > index 0000000..3c4825e
> > --- /dev/null
> > +++ b/tests/ref/fate/sub-charenc
> > @@ -0,0 +1 @@
> > +a39d7e299a8e25b4ffece0f8d64bf19e
> 
> I'll apply this soon if I see no comment.
> 

The attached version might be sexier though.

-- 
Clément B.
-------------- next part --------------
From 4a3f4e156c047aea5e3082708e1f5f57a8054d39 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Cl=C3=A9ment=20B=C5=93sch?= <ubitux at gmail.com>
Date: Wed, 20 Feb 2013 14:01:48 +0100
Subject: [PATCH] fate/subtitles: add character encoding conversion test.

---
 tests/fate/subtitles.mak   | 4 ++++
 tests/ref/fate/sub-charenc | 1 +
 2 files changed, 5 insertions(+)
 create mode 100644 tests/ref/fate/sub-charenc

diff --git a/tests/fate/subtitles.mak b/tests/fate/subtitles.mak
index 7b0dd43..e0681e5 100644
--- a/tests/fate/subtitles.mak
+++ b/tests/fate/subtitles.mak
@@ -52,6 +52,10 @@ fate-sub-vplayer: CMD = md5 -i $(SAMPLES)/sub/VPlayer_capability_tester.txt -f a
 FATE_SUBTITLES_ASS-$(call DEMDEC, WEBVTT, WEBVTT) += fate-sub-webvtt
 fate-sub-webvtt: CMD = md5 -i $(SAMPLES)/sub/WebVTT_capability_tester.vtt -f ass
 
+FATE_SUBTITLES_CHARENC-$(HAVE_ICONV) = fate-sub-charenc
+FATE_SUBTITLES_ASS-$(call DEMDEC, MICRODVD, MICRODVD) += $(FATE_SUBTITLES_CHARENC-yes)
+fate-sub-charenc: CMD = md5 -sub_charenc cp1251 -i $(SAMPLES)/sub/cp1251-subtitles.sub -f ass
+
 FATE_SUBTITLES-$(call ENCMUX, ASS, ASS) += $(FATE_SUBTITLES_ASS-yes)
 FATE_SUBTITLES += $(FATE_SUBTITLES-yes)
 
diff --git a/tests/ref/fate/sub-charenc b/tests/ref/fate/sub-charenc
new file mode 100644
index 0000000..3c4825e
--- /dev/null
+++ b/tests/ref/fate/sub-charenc
@@ -0,0 +1 @@
+a39d7e299a8e25b4ffece0f8d64bf19e
-- 
1.8.1.4

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130222/dac0eae1/attachment.asc>