[FFmpeg-devel] [PATCH 2/3] pmpdec: fix signedness

[Michael Niedermayer]

On Sat, Feb 23, 2013 at 11:46:56PM +0100, Reimar Döffinger wrote:
> 
> 
> On 23 Feb 2013, at 22:08, Michael Niedermayer <michaelni at gmx.at> wrote:
> 
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > ---
> > libavformat/pmpdec.c |    4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/libavformat/pmpdec.c b/libavformat/pmpdec.c
> > index 358f7b6..38eba14 100644
> > --- a/libavformat/pmpdec.c
> > +++ b/libavformat/pmpdec.c
> > @@ -44,7 +44,7 @@ static int pmp_header(AVFormatContext *s)
> >     PMPContext *pmp = s->priv_data;
> >     AVIOContext *pb = s->pb;
> >     int tb_num, tb_den;
> > -    int index_cnt;
> > +    unsigned index_cnt;
> >     int audio_codec_id = AV_CODEC_ID_NONE;
> >     int srate, channels;
> >     int i;
> > @@ -93,7 +93,7 @@ static int pmp_header(AVFormatContext *s)
> >     channels = avio_rl32(pb) + 1;
> >     pos = avio_tell(pb) + 4*index_cnt;
> >     for (i = 0; i < index_cnt; i++) {
> > -        int size = avio_rl32(pb);
> > +        unsigned size = avio_rl32(pb);
> 
> Why not go all the way and use uint32_t ?
> Seems safest to do.

changed


> All patches look ok to me.

applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130224/7659c50a/attachment.asc>