[FFmpeg-devel] [PATCH] Handling special characters in a URL.

[Stefano Sabatini]

On date Wednesday 2013-02-27 15:08:50 +0100, Stefano Sabatini encoded:
> On date Tuesday 2013-02-26 08:07:46 +0530, Senthilnathan Maadasamy encoded:
> > On Sat, Feb 23, 2013 at 12:14 AM, Stefano Sabatini <stefasab at gmail.com>wrote:
> [...]
> > From 4cce32a39623f920b68ea071710a599d9e92324f Mon Sep 17 00:00:00 2001
> > From: Senthilnathan M <senthilnathan.maadasamy at gmail.com>
> > Date: Sun, 10 Feb 2013 23:08:52 +0530
> > Subject: [PATCH] Support for special characters in URL
> > 
> > Signed-off-by: Senthilnathan M <senthilnathan.maadasamy at gmail.com>
> > ---
> >  libavformat/utils.c |   46 ++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 46 insertions(+)
[...]
> LGTM and thanks.
> 
> There are a few align issues but no need to send another patch. I'll
> apply it soon if there are no comments from other devs.

Applied with a few cosmetics changes (vertical align and spacing,
order of params, and now returns void since the error code is not
used, feel free to flame me if you don't like them).

Thanks again.

BTW it is still failing with:
ffmpeg -i 'http://samples.mplayerhq.hu/V-codecs/N264/Video%20demo-1.avi' -y fds.avi
ffmpeg version N-50356-g4a8fc1d Copyright (c) 2000-2013 the FFmpeg developers
[...]
[avi @ 0x20ec6c0] max_analyze_duration 5000000 reached at 5000000 microseconds
[avi @ 0x20ec6c0] Could not find codec parameters for stream 0 (Video: none (N264 / 0x3436324E), 352x288): unknown codec
Consider increasing the value for the 'analyzeduration' and 'probesize' options
Guessed Channel Layout for  Input Stream #0.1 : mono
Input #0, avi, from 'http://samples.mplayerhq.hu/V-codecs/N264/Video%20demo-1.avi':
  Duration: 00:00:51.40, start: 0.000000, bitrate: 1071 kb/s
    Stream #0:0: Video: none (N264 / 0x3436324E), 352x288, 25 fps, 25 tbr, 25 tbn, 25 tbc
    Stream #0:1: Audio: pcm_alaw ([6][0][0][0] / 0x0006), 8000 Hz, mono, s16, 64 kb/s
[buffer @ 0x2120260] Unable to parse option value "-1" as pixel format
Error opening filters!

and the error message is misleading, maybe we should add a check
before we pass -1 to the buffer source.
-- 
FFmpeg = Fancy and Faithless Mystic Peaceless Evanescent Geisha