[FFmpeg-devel] [PATCH] dec/developer: Add Valgrind / Address Sanitizer to the patch checklist

Stefano Sabatini stefasab at gmail.com
Sat Jan 12 16:45:55 CET 2013


On date Saturday 2013-01-12 16:28:27 +0100, Michael Niedermayer encoded:
> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> ---
>  doc/developer.texi |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/doc/developer.texi b/doc/developer.texi
> index 7e4b12c..0439a50 100644
> --- a/doc/developer.texi
> +++ b/doc/developer.texi
> @@ -507,6 +507,9 @@ send a reminder by email. Your patch should eventually be dealt with.
>      Make sure you check the return values of function and return appropriate
>      error codes. Especially memory allocation functions like @code{av_malloc()}
>      are notoriously left unchecked, which is a serious problem.
> + at item
> +    Test your code with valgrind and or Address Sanitizer to ensure its free

Also specify the name of the tool, so that it's clear what "Address
Sanitizer" refers to.

> +    of leaks, out of array accesses, etc.
>  @end enumerate

LGTM otherwise.
-- 
FFmpeg = Fantastic Faithful Merciless Philosofic Explosive Glue


More information about the ffmpeg-devel mailing list