[FFmpeg-devel] [PATCH] HTTP cookie support

[Stefano Sabatini]

On date Sunday 2013-01-13 21:38:53 -0500, Micah Galizia encoded:
> OK,
> 
> All nits addressed and I changed to the while instead of do ... it kind of
> feels strange setting things to NULL and keeping an extra pointer around,
> but it does cut down a few lines ... it also feels strange using a goto.
> Documentation patch is the same, but I regenerated because I used `git
> reset` to roll them both back and I wasn't sure if it'd affect `git am` on
> your end.
> 
> Anyway, thanks for the review.
> 

> PS: is there a difference between "nit" and "Nit"?

None.

> From e256881955527ef72c1016a41f8f2129a0308cd4 Mon Sep 17 00:00:00 2001
> From: Micah Galizia <micahgalizia at gmail.com>
> Date: Sun, 13 Jan 2013 21:32:57 -0500
> Subject: [PATCH 1/2] add HTTP protocol cookie support
> 
> ---
>  libavformat/http.c |  115 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 115 insertions(+)
[...]
> +/**
> + * Create a string containing cookie values for use as a HTTP cookie header
> + * field value for a particular path and domain from the cookie values stored in
> + * the HTTP protocol context. The cookie string is stored in *cookies.
> + *
> + * @return a negative value if an error condition occurred, 0 otherwise
> + */
> +static int get_cookies(HTTPContext *s, char **cookies, const char *path,
> +                       const char *domain)
> +{
[...]
> +        if (ret) {

nit: ret < 0

[...]
> From 1d8141ae410df6c44eb4464cba9df45898ea4669 Mon Sep 17 00:00:00 2001
> From: Micah Galizia <micahgalizia at gmail.com>
> Date: Sun, 13 Jan 2013 21:33:20 -0500
> Subject: [PATCH 2/2] document HTTP protocol cookie support
> 
> ---
>  doc/protocols.texi |   19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
[...]

LGTM, I'll fix the nit myself and will push if I read no more comments
in 1 day.

Thank you.
-- 
FFmpeg = Fancy and Freak Meaningless Powered Erratic Gigant