[FFmpeg-devel] [PATCH] latmenc: Check for LOAS sync word

[James Almer]

On 16/01/13 6:06 PM, Michael Niedermayer wrote:
> On Wed, Jan 16, 2013 at 05:25:03PM -0300, James Almer wrote:
>> On 16/01/13 5:17 PM, Michael Niedermayer wrote:
>>> If extradata is set then ADTS would be muxed into LATM creating a
>>> invalid output
>>> also the code is indented in a way that does not match the actual
>>> relation of the statements
>>
>> Encoders should not send ADTS packets with extradata. None currently does 
>> either.
> 
> theres no need for a encoder, the input can come straight from a
> container

There's a previous check for remuxing that i left untouched (CodecID 
AV_CODEC_ID_AAC_LATM).

>> And i left indentation like that on purpose as other people asked me to
>> do, to make the review easier (Leaving that for a cosmetic patch).
>>
>> Do you want me to keep the ADTS check untouched and outside the extradata 
>> check then?
> 
> yes

Ok, will send in a bit.

Regards.