[FFmpeg-devel] [PATCH] oggdec: #if 0 disabled code

[Michael Niedermayer]

On Sun, Jan 20, 2013 at 04:54:16PM +0000, Carl Eugen Hoyos wrote:
> Michael Niedermayer <michaelni <at> gmx.at> writes:
> 
> >      os->serial  = serial;
> >      return 0;
> > -
> > +#if 0
> 
> (I wonder if you shouldn't leave the empty line.)

left


> 
> >      buf     = os->buf;
> >      bufsize = os->bufsize;
> >      codec   = os->codec;
> > @@ -204,6 +204,7 @@ static int ogg_replace_stream
> >      os->codec   = codec;
> > 
> >      return 0;
> > +#endif
> 
> LGTM

applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130121/e734c5e1/attachment.asc>