[FFmpeg-devel] [PATCH] lavd/v4l2: sanitize logic of device_try_init(), so that it properly signal errors

[Luca Abeni]

On 01/22/2013 09:44 PM, Stefano Sabatini wrote:
[...]
>> And third attempt (the previous one was apparently an old patch).
>> --
>> FFmpeg = Free and Freak Mournful Pure Exxagerate Goblin
>
>>  From 1f694c601d5b1f2391f550fea1f8198fb72f5caa Mon Sep 17 00:00:00 2001
>> From: Stefano Sabatini <stefasab at gmail.com>
>> Date: Tue, 15 Jan 2013 12:45:13 +0100
>> Subject: [PATCH] lavd/v4l2: sanitize logic of device_try_init(), so that it
>>   properly signal errors
>>
>> Make device_try_init() return an error value, and allow to properly
>> report errors which are not due to a wrong pixel/codec configuration.
>>
>> In particular, report intelligible feedback in case of busy device.
>> ---
>>   libavdevice/v4l2.c |   69 +++++++++++++++++++++++++++++-----------------------
>>   1 file changed, 39 insertions(+), 30 deletions(-)
>
> Ping, will push in a few days if I read no comments.
Sorry, I do not think I've seen this patch before (or if I received it, I
somehow managed to lose it...).
So, if you want my feedback, can you send it again?

(anyway, the patch description seems to indicate an uncontroversial enough patch)



				Luca