[FFmpeg-devel] [PATCH] libopenjpegenc: add 9-15 bit RGB output

[Michael Bradshaw]

On Wed, Jan 23, 2013 at 6:53 AM, Paul B Mahol <onemda at gmail.com> wrote:

> Patch is silly. It adds option to shift pixel values by some random
> unlimited number.
>

It's not unlimited. The range [0, 7] is specified.


> Even feature is far from being useful at all and it is not documented at
> all.
>

I felt naming and documenting awkward for this feature, so I left it undone
(rather than done poorly). Suggestions are welcome.


> IMHO it is much better to support planar RGB stuff, you just need to
> copy plane data
> in right order. (Instead of manually deinterleaving (slow) packed RGB).
>
> So you should add support for planar rgb pixel formats in
> decoder/encoder instead.


Alright, attached is a version that does that (needs reviewing). Now people
can decide which they prefer. One downside is that it doesn't support
alpha, and there aren't any conversion in swscale (as far as I know) to
allow people to go rgb48 -> bgrp10 etc. But it does seems like a more
"proper" solution.

On a side note, why is the planar format bgr while the packed format
(typically) rgb? Why wasn't the planar format made rgb as well?

Thanks,

Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-libopenjpegenc-add-support-for-pix-fmt-gbrp-8-16-bit.patch
Type: application/octet-stream
Size: 3220 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130123/37bdbcf9/attachment.obj>