[FFmpeg-devel] [PATCH] lavfi/trim: use AV_OPT_TYPE_DURATION

[Derek Buitenhuis]

On 7/10/2013 2:27 PM, Paul B Mahol wrote:
> This fixes one of major flaws.

Please documented which flaws these are in the
commit message.

> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> ---
>  doc/filters.texi   | 48 ++++++++++++++++++++++++++++++++++++++++++------
>  libavfilter/trim.c | 24 ++++++++++++------------
>  2 files changed, 54 insertions(+), 18 deletions(-)

[...]

> -Timestamp (in seconds) of the start of the kept section. I.e. the audio sample
> +Specify time of the start of the kept section. I.e. the audio sample

"Specifies the starting time of section to keep. i.e. the audio sample
('i.e.' is ALWAYS lower case)

>  with the timestamp @var{start} will be the first sample in the output.
> +The accepted syntax is:
> + at example
> +[-]HH[:MM[:SS[.m...]]]
> +[-]S+[.m...]
> + at end example
> +See also the function @code{av_parse_time()}.

Do we not have one place to document "duration" format? Seems silly
to restate it for every filter.

> -Timestamp (in seconds) of the first audio sample that will be dropped. I.e. the
> +Specify time of the first audio sample that will be dropped. I.e. the

Same as above.

> +The accepted syntax is:
> + at example
> +[-]HH[:MM[:SS[.m...]]]
> +[-]S+[.m...]
> + at end example
> +See also the function @code{av_parse_time()}.

Same as above.

> -Maximum duration of the output in seconds.
> +Specify maximum duration of the output.

s/Specify/Specifies/

> +The accepted syntax is:
> + at example
> +[-]HH[:MM[:SS[.m...]]]
> +[-]S+[.m...]
> + at end example
> +See also the function @code{av_parse_time()}.

Same as above.

> -Timestamp (in seconds) of the start of the kept section. I.e. the frame with the
> +Specify time of the start of the kept section. I.e. the frame with the
>  timestamp @var{start} will be the first frame in the output.
> +The accepted syntax is:
> + at example
> +[-]HH[:MM[:SS[.m...]]]
> +[-]S+[.m...]
> + at end example
> +See also the function @code{av_parse_time()}.

Again.

> -Timestamp (in seconds) of the first frame that will be dropped. I.e. the frame
> +Specify time of the first frame that will be dropped. I.e. the frame
>  immediately preceding the one with the timestamp @var{end} will be the last
>  frame in the output.
> +The accepted syntax is:
> + at example
> +[-]HH[:MM[:SS[.m...]]]
> +[-]S+[.m...]
> + at end example
> +See also the function @code{av_parse_time()}.

Again.

> -Maximum duration of the output in seconds.
> +Specify maximum duration of the output.
> +The accepted syntax is:
> + at example
> +[-]HH[:MM[:SS[.m...]]]
> +[-]S+[.m...]
> + at end example
> +See also the function @code{av_parse_time()}.

Again.

Code itself seems reasonable.

- Derek