[FFmpeg-devel] [PATCH 3/5] ff_network_wait_fd_timeout(): check for interrupt before operation

[Michael Niedermayer]

On Fri, Jul 12, 2013 at 08:21:19PM +0200, Lukasz M wrote:
> >> So far all you described was done internally. TCP could be used as
> >> black box. There was an API to break a loop, end of story,
> >> For me getting descriptor and polling it would break modulatiry and
> >> duplicates code.
> >> Your commit changes that logic and I pointed it to discuss it. I think
> >> that's the idea of community.
> >> And I really don't see a reason to discuss FTP protocol here and all
> >> your doubs about it, because there was a time for it when I submitted
> >> it.
> >
> > I didn't mean to offend you.
> > We discuss your code because you mentioned it as an application for
> > further enhancements of interrupt feature.
> > My point is that you misuse the interrupt feature (and depend on
> > undocumented implementation details). It is originally meant for
> > immediate termination of stream processing, and that is the only thing
> > it is guaranteed to do well. Although it is not worded anywhere in
> > documentation; If i am wrong here, let more experienced developers
> > correct me.
> 
> I think there is not many people following this thread :)
> I have checked some more and I have to admit all seems you have right,

ok, applied
thanks


> but doxy for AVIOInterruptCB is horrible.
> I will submit some changes for ftp after your changes are merged.
> 
> Best Regards,
> Lukasz Marek
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130712/39fef9e2/attachment.asc>