[FFmpeg-devel] [PATCH] avfilter/vf_scale: allow overriding in/out yuv colorspace type

[Michael Niedermayer]

On Sun, Jul 14, 2013 at 12:26:15PM +0200, Stefano Sabatini wrote:
> On date Friday 2013-07-12 12:21:14 +0200, Michael Niedermayer encoded:
> > On Fri, Jul 12, 2013 at 09:16:23AM +0200, Stefano Sabatini wrote:
> > > On date Friday 2013-07-12 00:52:08 +0200, Michael Niedermayer encoded:
> > > > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > > > ---
> > > >  doc/filters.texi       |   15 +++++++++++++++
> > > >  libavfilter/vf_scale.c |   44 ++++++++++++++++++++++++++++++++++++++++++++
> > > >  2 files changed, 59 insertions(+)
> > > > 
> > > > diff --git a/doc/filters.texi b/doc/filters.texi
> > > > index 92f8612..5f6e11b 100644
> > > > --- a/doc/filters.texi
> > > > +++ b/doc/filters.texi
> > > > @@ -6201,6 +6201,21 @@ applies a bilinear scaling algorithm.
> > > >  @item size, s
> > > >  Set the video size, the value must be a valid abbreviation or in the
> > > >  form @var{width}x at var{height}.
> > > > +
> > > > + at item inyuvtype
> > > > + at item outyuvtype
> > > > +In/Output YCbCr colorspace type
> > > 
> > > Set in/output ...
> > > 
> > > > + at table @option
> > > 
> > > @table @samp
> > 
> > changed
> > 
> > 
> > > 
> > > > + at item jpeg
> > > > +Full 0-255 jpeg style
> > > > +
> > > > + at item 709
> > > > +ITU Rec BT709
> > > > +
> > > > + at item 601
> > > > +ITU Rec BT601
> > > > + at end table
> > > > +
> > > >  @end table
> > > 
> > > Which is the default value?
> > 
> 
> > what it was before, when the option isnt specified, thats not a
> > constant independant of the pixel format
> 
> So something like this might work:
> If not specified, the colorspace type depends on the pixel format.

added


>
> Also I'd prefer the use of named constants with an explicit "auto"
> value which is adopted by default, and which is shown when the options
> are automatically printed.

how should we support nummerically specified matrixes using named
constants ?
also i intend to add "auto" mode (not default) in a subsequent
patch and make it default once it works.


>
> Even like this it is still confusing and doesn't really explain in
> which scenario the option is useful, adding an explaining paragraph
> would be greatly useful.

added

i will post a updated patchset

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130714/c7d35561/attachment.asc>