[FFmpeg-devel] [PATCH] WebVTT demuxer - save cue id and settings as side data

[Clément Bœsch]

On Fri, May 31, 2013 at 04:32:18PM -0700, Matthew Heaney wrote:
> OK, thanks for the tips.  I determined that there was indeed a small
> problem: the webvtt demuxer must specify the AVFMT_FLAG_KEEP_SIDE_DATA flag
> in order to prevent the side data from being merged into the packet data.
>  This error didn't show up when copying a vtt input file to a webm output
> file text track, but it did manifest when converting a vtt to an ass.
> 

No, that's not correct.

The problem is that ff_subtitles_queue_insert() is called with the length
including the settings.

It is normal to have the side data as part of the packet, you should not
change that flag.

PS: please do not top-post on this mailing-list

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130601/26cd027a/attachment.asc>