[FFmpeg-devel] [PATCH] mpegts: Enable muxing of SMPTE KLV data

[Jeff Blackburne]

On Thu, Jun 13, 2013 at 2:58 PM, Michael Niedermayer <michaelni at gmx.at>wrote:

> On Thu, Jun 13, 2013 at 09:59:10AM -0700, Jeff Blackburne wrote:
> > On Thu, Jun 13, 2013 at 7:52 AM, Michael Niedermayer <michaelni at gmx.at
> >wrote:
> >
> > > On Tue, Jun 11, 2013 at 09:59:01AM -0700, Jeff Blackburne wrote:
> > > > This is basically a re-post of Peter Ross's patch to mux SMPTE
> > > > key-length-value data. See these archive links:
> > > > http://ffmpeg.org/pipermail/ffmpeg-devel/2012-October/132381.html
> > > > http://ffmpeg.org/pipermail/ffmpeg-devel/2012-December/135502.html
> > > >
> > > > The demux patch has already been accepted, and works well for me.
> I've
> > > > tested this patch as well, and it works as expected.
> > >
> > > Didnt that patch write all packets non interleaved at the begin ?
> > >
> >
> > No. But in my experience most KLV packets have
> > pts = dts = AV_NOPTS_VALUE, which I think would cause that behavior.
> > When I construct packets with reasonable pts/dts values, they are
> > correctly interleaved.
> >
> >
> > > also patch looks mangled and lacks correct author & commit message
> > >
> >
> > Ok. Output of git format-patch is now attached. Hopefully
> > gmail won't screw that up.
> >
> > -Jeff
>
> >  mpegtsenc.c |   14 ++++++++++++--
> >  1 file changed, 12 insertions(+), 2 deletions(-)
> > 1ad95e91c0c86557333b75b1cc4b69544cf0661f  mpegts_klv_mux.patch
> > From f36564c52aeb32fa4bc922f5558947c558181724 Mon Sep 17 00:00:00 2001
> > From: Jeff Blackburne <jblackburne at gmail.com>
> > Date: Thu, 11 Apr 2013 09:57:15 -0700
> > Subject: [PATCH] mpegts: Enable muxing of SMPTE KLV metadata
>
> If this is as you say "basically a re-post of Peter Ross's patch"
> then Peter should be in the author field
>

Fine with me. I guess I'll ... replace my name with his? Attached is the
result.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mpegts_klv_mux_pross.patch
Type: application/octet-stream
Size: 1617 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130613/53866308/attachment.obj>