[FFmpeg-devel] [PATCH] lavfi: add spp filter.

[Clément Bœsch]

On Mon, Jun 10, 2013 at 02:58:08PM +0200, Michael Niedermayer wrote:
[...]
> > + at table @option
> > + at item quality
> > +Set quality. This option defines the number of level for averaging. It accepts
> > +an integer in the range 0-6. If set to @code{0}, the filter will have no
> > +effect. A value of @code{6} means the higher quality. Default value is
> > + at code{3}.
> 
> something like "for each +1 the speed drops by a factor of 2"
> should be added
> 

Added.

[...]
> > +    { "qp", "force a constant quantizer parameter", OFFSET(qp), AV_OPT_TYPE_INT, {.i64 = 0}, 0, INT_MAX, FLAGS },
> 
> INT_MAX seems a bit high
> 

Set to 63

> patch should be ok otherwise if it gives same resukts & same speed
> as mp-spp
> 

Tested framecrc with various configuration and seems to match.

Speed identical as well.

Pushed, thanks.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130614/67a06bfd/attachment.asc>