[FFmpeg-devel] [PATCH] lavfi/mp: remove some pp filters.

[Clément Bœsch]

On Thu, Jun 13, 2013 at 11:53:29PM +0000, Carl Eugen Hoyos wrote:
> Clément Bœsch <ubitux <at> gmail.com> writes:
> 
> >  - fspp seems to be a 1d version of spp; users seem to 
> >    prefer spp (denouncement: michaelni, iive, microchip).
> 
> Is it (measurably) faster?
> 

About 2x faster here.

> >  - pp7 is a special version of spp, it might be worth 
> >    including it in the native spp at some point.
> 
> If it is worth including (I don't know), then it should 
> probably be removed once it is included.
> 

I doubt anyone will do the effort to include pp7 properly into our spp.
And I don't think adding yet another pp filter is a good idea (all those
different filters are confusing for users)

> >  - uspp is a slow and less effective spp
> 
> Sorry if I misunderstand but the link you gave in your 
> other mail seemed to indicate that it is actually a 
> higher quality version of spp.
> 

I looked better to me with spp (at least with qp=32)

> I probably just don't understand what advantages we 
> have by dropping the filters.
> 

Because the mp wrapper is meant to be a temporary solution, and because
having a native version of all these filters is IMO a bad idea (we'd
better have one or two good filters for one task, not 100 maybe-used
filters).

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130614/00ae68f1/attachment.asc>