[FFmpeg-devel] [PATCH 1/2] lavu/hash: Add support for SHA-2 512

[James Almer]

On 15/06/13 6:38 PM, Michael Niedermayer wrote:
> On Sat, Jun 15, 2013 at 04:10:44PM -0300, James Almer wrote:
>> On 15/06/13 6:08 AM, Michael Niedermayer wrote:
>>> On Sun, Jun 02, 2013 at 05:58:15PM -0300, James Almer wrote:
>>>>
>>>> Signed-off-by: James Almer <jamrial at gmail.com>
>>> [...]
>>>> diff --git a/libavutil/hash.h b/libavutil/hash.h
>>>> index 5dd8712..9bf715e 100644
>>>> --- a/libavutil/hash.h
>>>> +++ b/libavutil/hash.h
>>>> @@ -58,7 +58,7 @@ const char *av_hash_get_name(const struct AVHashContext *ctx);
>>>>   * with larger sizes will not be considered an ABI change and should not cause
>>>>   * your code to overflow a buffer.
>>>>   */
>>>> -#define AV_HASH_MAX_SIZE 32
>>>> +#define AV_HASH_MAX_SIZE 64
>>>
>>> this needs a minor version bump
>>
>> This is not public API, though. The header is not being installed yet.
>> Should i bump it anyway?
> 
> without a bump an application that needs "support for SHA-2 512"
> has no means to declare a dependancy on a libavutil that supportd
> it.
> And even worse libavformat itself couldnt declare a dependancy so
> applications using libavformat couldnt be sure that the latest
> libavformat supports SHA-2 512 because it could be linked to a
> older libavutil (with same version but no SHA-2 512 in hash.*)
> 

Bumped minor and pushed all three patches to github/jamrial, branch crypto.

Regards.