[FFmpeg-devel] [PATCH] lavu/opencl:Check the opencl init flag in uninit

Michael Niedermayer michaelni at gmx.at
Thu Jun 27 13:13:05 CEST 2013


On Thu, Jun 27, 2013 at 02:46:03PM +0800, Wei Gao wrote:
> Hi
> 
> We found that the opencl uninit funciton maybe called befor the init
> function when we debug opencl scale filter, if under this condition, the
> init will fail. So I add the check init flag code.
> 
> Is it OK?

why and how exactly is uninit called before init

also you are the maintainer of the code, that means you are
responsible for makeing sure it works & is correct, and ultimately
if this isnt correct its primarely your problem to deal with later.

Now without knowing why and how uninit() is called first, if instead
of at 0 it is at 1 because something else called init uninit would
decrease it. It seems quite unlikely that both would be correct
    

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130627/3c63ccc3/attachment.asc>


More information about the ffmpeg-devel mailing list