[FFmpeg-devel] [PATCH] libgme support

[wm4]

On Fri, 28 Jun 2013 15:23:10 +0000 (UTC)
Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:

> Carl Eugen Hoyos <cehoyos <at> ag.or.at> writes:
> 
> > > libgme checks the 4 bytes of the start of the file only. 
> > > I'm returning AVPROBE_SCORE_MAX / 2 hoping to reduce 
> > > potential breakage.
> > 
> > At least subtract one (or use AVPROBE_SCORE_MAX / 4 + 1)

Sounds good. I could add the file extension too. Actually I could add a
check for the file extension too. So what should happen if the file
extension is known to GME: just return AVPROBE_SCORE_EXTENSION? Or
combine it somehow with the header check and improve the probe score if
it matches? Or always require the file extension to match?

I see many possibilities, and the probe score is a bit arbitrary.

If anyone is interested in having a look, the API is here:

http://code.google.com/p/game-music-emu/source/browse/trunk/gme/gme.h#204

> Or better, see commit c605adb to give the mpeg and mp3 
> demuxer a better chance to raise their score.

OK, I can add that too.

> I believe that your license header makes no sense, but 
> this is completely up to you.

Not sure what's the problem with it. Am I overlooking something obvious?