[FFmpeg-devel] [PATCH] libavfromat/flvenc.c: Preserve the 'amf0' data stream written by Adobe Flash Media Servers while doing a data stream copy

Carl Eugen Hoyos cehoyos at ag.or.at
Thu Mar 7 19:47:51 CET 2013


Benedict Endemann <bendemann <at> make.tv> writes:

> -        avio_w8(pb, AMF_DATA_TYPE_STRING);
> -        put_amf_string(pb, "onTextData");
> -        avio_w8(pb, AMF_DATA_TYPE_MIXEDARRAY);

> +        if (enc->codec_id == AV_CODEC_ID_TEXT) {
> +            avio_w8(pb, AMF_DATA_TYPE_STRING);
> +            put_amf_string(pb, "onTextData");
> +            avio_w8(pb, AMF_DATA_TYPE_MIXEDARRAY);
> +            avio_wb32(pb, 2);

...

Please do not mix functional with cosmetic changes, 
ie don't re-indent so many lines but leave them 
untouched. That makes reviewing easier.
You may send a second patch to do the indentation 
change.

Thank you, Carl Eugen



More information about the ffmpeg-devel mailing list