[FFmpeg-devel] [PATCH 03/23] hpeldsp: add half-pel functions (currently copies of dsputil).

[Ronald S. Bultje]

Hi,

On Tue, Mar 12, 2013 at 7:32 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Tue, Mar 12, 2013 at 07:28:13AM -0700, Ronald S. Bultje wrote:
>> From: "Ronald S. Bultje" <rsbultje at gmail.com>
> [...]
>> +static inline void FUNCC(OPNAME ## _pixels2_xy2)(uint8_t *p_block, const uint8_t *p_pixels, ptrdiff_t line_size, int h)\
>> +{\
>> +        int i, a0, b0, a1, b1;\
>> +        pixel *block = (pixel*)p_block;\
>> +        const pixel *pixels = (const pixel*)p_pixels;\
>
> comparing source and destination of the copy:
>
> -static inline void FUNCC(OPNAME ## _pixels2_xy2)(uint8_t *_block, const uint8_t *_pixels, ptrdiff_t line_size, int h)\
> +static inline void FUNCC(OPNAME ## _pixels2_xy2)(uint8_t *p_block, const uint8_t *p_pixels, ptrdiff_t line_size, int h)\
>  {\
>          int i, a0, b0, a1, b1;\
> -        pixel *block = (pixel*)_block;\
> -        const pixel *pixels = (const pixel*)_pixels;\
> +        pixel *block = (pixel*)p_block;\
> +        const pixel *pixels = (const pixel*)p_pixels;\
>          line_size >>= sizeof(pixel)-1;\
>          a0= pixels[0];\
>          b0= pixels[1] + 2;\
>
> I dont really mind the change but i suspect this is unintended

Uhm, yeah, not sure how that happened...

Ronald