[FFmpeg-devel] [FFmpeg-user] prores4444 to dpx: colourshift & translation, dpxenc.c patch

[ArnoB]

On 14 mrt 2013, at 16:35, ArnoB wrote:

> 
> On 14 mrt 2013, at 14:58, compn wrote:
> 
>> On Thu, 14 Mar 2013 14:10:49 +0100, ArnoB wrote:
>>> Hello,
>>> 
>>> First, my apologies for cross posting, but I think this belongs
>>> in the dev-list.
>>> 
>>> I dug into the code and managed to find a very simple solution
>>> for the problem I encountered. I added a line to libavcodec/dpexenc.c
>>> diff dpxenc.new.c dpxenc.c:
>>> 
>>> 215d214
>>> <     write32(buf + 808, HEADER_SIZE); /* data offset */
>>> 
>>> (I hope I'm providing this the correct way.)
>> 
>> we prefer git diff or diff -u (unified diffs) as they are more human
>> readable.
>> 
>> -compn
> 
> thanks compn!
> 
> here then, does that look better?
> 
> --- libavcodec/dpxenc.c	2013-03-14 12:49:02.000000000 +0100
> +++ libavcodec/dpxenc.c.orig	2013-03-08 14:58:27.000000000 +0100
> @@ -212,7 +212,6 @@
>     buf[803] = s->bits_per_component;
>     write16(buf + 804, (s->bits_per_component == 10 || s->bits_per_component == 12) ?
>                        1 : 0); /* packing method */
> -    write32(buf + 808, HEADER_SIZE); /* data offset */
> 
>     /* Image source information header */
>     write32(buf + 1628, avctx->sample_aspect_ratio.num);
> 
> 
> gr
> arno
> 

sorry for the correction, of course the - has to be a +.
I should have swapped the fileorder in diff.

% diff -u libavcodec/dpxenc.c.orig libavcodec/dpxenc.c
--- libavcodec/dpxenc.c.orig	2013-03-08 14:58:27.000000000 +0100
+++ libavcodec/dpxenc.c	2013-03-14 12:49:02.000000000 +0100
@@ -212,6 +212,7 @@
     buf[803] = s->bits_per_component;
     write16(buf + 804, (s->bits_per_component == 10 || s->bits_per_component == 12) ?
                        1 : 0); /* packing method */
+    write32(buf + 808, HEADER_SIZE); /* data offset */
 
     /* Image source information header */
     write32(buf + 1628, avctx->sample_aspect_ratio.num);