[FFmpeg-devel] [PATCH 1/2] lavu/opt: add AV_OPT_VIDEO_RATE option

[Stefano Sabatini]

On date Sunday 2013-03-17 13:12:33 +0000, Paul B Mahol encoded:
> On 3/17/13, Stefano Sabatini <stefasab at gmail.com> wrote:
> > On date Sunday 2013-03-17 11:07:15 +0000, Paul B Mahol encoded:
> >> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> >> ---
> >>  doc/APIchanges      |  3 +++
> >>  libavutil/opt.c     | 26 +++++++++++++++++++++++++-
> >>  libavutil/opt.h     |  1 +
> >>  libavutil/version.h |  4 ++--
> >>  4 files changed, 31 insertions(+), 3 deletions(-)
[...]
> > What about a binary interface:
> > int av_opt_set_video_rate(void *obj, const char *name, AVRational  val, int
> > search_flags);
> > int av_opt_get_video_rate(void *obj, const char *name, int search_flags,
> > AVRational *out_val);
> >
> > This should mostly rely on av_opt_{get,set}_q(), with a few additional
> > checks on type and range validity.
> 
> You want to say that such functions are missing and not optional
> (comparing to other variants)?

They are optional, but would be better to include them in the same
commit for completeness and overall consistency.

No technical objections about the patch itself (but I'm not a
maintainer of that file).
-- 
FFmpeg = Fundamentalist and Fiendish Mysterious Philosofic Educated Guru