[FFmpeg-devel] [PATCH] libavcodec/mips: fix for mips optimized fp fft with hard coded tables disabled

[Michael Niedermayer]

On Thu, Feb 28, 2013 at 03:55:33PM +0100, Nedeljko Babic wrote:
> Floating point FFT (nips optimized) breaks when hard coded tables are
> not enabled because MIPS optimization of floating point FFT uses only
> ff_init_ff_cos_tabs(16) which is not enabled by default in that case.
> 
> This patch is fixing it.
> 
> Signed-off-by: Nedeljko Babic <nbabic at mips.com>
> ---
>  libavcodec/fft.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/libavcodec/fft.c b/libavcodec/fft.c
> index 00c434a..00de2bf 100644
> --- a/libavcodec/fft.c
> +++ b/libavcodec/fft.c
> @@ -168,9 +168,13 @@ av_cold int ff_fft_init(FFTContext *s, int nbits, int inverse)
>      if (ARCH_ARM)     ff_fft_fixed_init_arm(s);
>  #endif
>  
> +#if (HAVE_MIPSFPU) && (CONFIG_FFT_FLOAT)
> +    ff_init_ff_cos_tabs(16);
> +#else
>      for(j=4; j<=nbits; j++) {
>          ff_init_ff_cos_tabs(j);
>      }
> +#endif

maybe iam missing something but why is this not done in
ff_fft_init_mips() ?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is what and why we do it that matters, not just one of them.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130319/18cdfc6f/attachment.asc>