[FFmpeg-devel] [PATCH 3/3] fate: add ebur128 metadata test.

[Clément Bœsch]

On Mon, Mar 18, 2013 at 10:34:06PM +0100, Stefano Sabatini wrote:
> On date Saturday 2013-03-16 16:50:13 +0100, Clément Bœsch encoded:
> > ---
> >  tests/fate/filter.mak                  |   6 +
> >  tests/ref/fate/filter-metadata-ebur128 | 280 +++++++++++++++++++++++++++++++++
> >  2 files changed, 286 insertions(+)
> >  create mode 100644 tests/ref/fate/filter-metadata-ebur128
> > 
> > diff --git a/tests/fate/filter.mak b/tests/fate/filter.mak
> > index 6c3ce7e..74d7d48 100644
> > --- a/tests/fate/filter.mak
> > +++ b/tests/fate/filter.mak
> > @@ -58,6 +58,7 @@ FATE_SAMPLES_AVCONV += $(FATE_FILTER-yes)
> >  # Metadata tests
> >  #
> >  FILTER_METADATA_COMMAND = ffprobe$(EXESUF) -show_frames -of compact=nk=1:p=0 -bitexact -f lavfi
> 
> > +FILTER_METADATA_COMMAND2 = ffprobe$(EXESUF) -show_frames -of compact=p=0 -show_entries frame=pkt_pts,metadata -bitexact -f lavfi
> 
> you can remove -show_frames (or there is a bug)
> 

Maybe there is a bug then, because it doesn't work without. This option
sounds necessary to me though.

> >  
> >  SCENEDETECT_DEPS = FFPROBE LAVFI_INDEV MOVIE_FILTER SELECT_FILTER SCALE_FILTER \
> >                     AVCODEC AVDEVICE MOV_DEMUXER SVQ3_DECODER ZLIB
> > @@ -70,6 +71,11 @@ FATE_METADATA_FILTER-$(call ALLYES, $(SILENCEDETECT_DEPS)) += fate-filter-metada
> >  fate-filter-metadata-silencedetect: SRC = $(SAMPLES)/amrwb/seed-12k65.awb
> >  fate-filter-metadata-silencedetect: CMD = run $(FILTER_METADATA_COMMAND) "amovie='$(SRC)',silencedetect=d=-20dB"
> > 
> > +EBUR128_METADATA_DEPS = FFPROBE AVDEVICE LAVFI_INDEV AMOVIE_FILTER FLAC_DEMUXER FLAC_DECODER
> > +FATE_METADATA_FILTER-$(call ALLYES, $(EBUR128_METADATA_DEPS)) += fate-filter-metadata-ebur128
> > +fate-filter-metadata-ebur128: SRC = $(SAMPLES)/filter/seq-3341-7_seq-3342-5-24bit.flac
> > +fate-filter-metadata-ebur128: CMD = run $(FILTER_METADATA_COMMAND2) "amovie='$(SRC)',ebur128=metadata=1"
> > +
> >  FATE_SAMPLES_FFPROBE += $(FATE_METADATA_FILTER-yes)
> >  
> >  fate-filter: $(FATE_FILTER-yes) $(FATE_METADATA_FILTER-yes)
> > diff --git a/tests/ref/fate/filter-metadata-ebur128 b/tests/ref/fate/filter-metadata-ebur128
> > new file mode 100644
> > index 0000000..7a060bd
> > --- /dev/null
> > +++ b/tests/ref/fate/filter-metadata-ebur128
> > @@ -0,0 +1,280 @@
> > +pkt_pts=0|tag:lavfi.r128.M=-120.691|tag:lavfi.r128.S=-120.691|tag:lavfi.r128.I=-70.000|tag:lavfi.r128.LRA=0.000|tag:lavfi.r128.LRA.low=0.000|tag:lavfi.r128.LRA.high=0.000
> [...]
> > +pkt_pts=1329600|tag:lavfi.r128.M=-25.127|tag:lavfi.r128.S=-22.630|tag:lavfi.r128.I=-22.986|tag:lavfi.r128.LRA=4.990|tag:lavfi.r128.LRA.low=-26.240|tag:lavfi.r128.LRA.high=-21.250
> > +pkt_pts=1334400|tag:lavfi.r128.M=-24.909|tag:lavfi.r128.S=-22.673|tag:lavfi.r128.I=-22.991|tag:lavfi.r128.LRA=4.990|tag:lavfi.r128.LRA.low=-26.240|tag:lavfi.r128.LRA.high=-21.250
> 
> > +pkt_pts=1339200
> 
> This is suspect (no metadata in the last frame), LGTM otherwise.

The filter is "sample count" based; it will inject metadata into the frame
when the number of sample is reached (enough to make an analysis
basically). The last frame has < 4800 samples, so nothing to score.

Applied.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130319/39657b9a/attachment.asc>