[FFmpeg-devel] [PATCH] lavfi: phasescope filter

[Paul B Mahol]

On 3/26/13, Clement Boesch <ubitux at gmail.com> wrote:
> On Tue, Mar 26, 2013 at 10:36:54AM +0000, Paul B Mahol wrote:
> [...]
>> >> +static int config_input(AVFilterLink *inlink)
>> >> +{
>> >> +    AVFilterContext *ctx = inlink->dst;
>> >> +    PhaseScopeContext *p = ctx->priv;
>> >> +
>> >> +    p->nb_samples = FFMAX(1024, ((double)inlink->sample_rate /
>> >> av_q2d(p->frame_rate)) + 0.5);
>> >> +    inlink->partial_buf_size =
>> >> +    inlink->min_samples =
>> >> +    inlink->max_samples = p->nb_samples;
>> >> +
>> >
>> > Note that this might not work in some cases.
>>
>> When? Why?
>>
>
> See what I tried to fix here:
> http://ffmpeg.org/pipermail/ffmpeg-devel/2013-March/140649.html
> And the API discussion here:
> http://ffmpeg.org/pipermail/ffmpeg-devel/2013-March/140636.html
>
> The problem was worked around in ebur128 by implementing a request_frame()
> callback.

I see, I really dislike making trivial filters less trivial. So I'm
for whichever
solution that will make filters simplier instead of duplicating same code
all over again.

>
> [...]
>
> --
> Clement B.
>