[FFmpeg-devel] [PATCH] ffplay: use seek per time for ogg by default

[Michael Niedermayer]

On Sun, Mar 31, 2013 at 11:08:39PM +0200, Stefano Sabatini wrote:
> On date Sunday 2013-03-31 21:42:09 +0200, Michael Niedermayer encoded:
> > Fixes Ticket2283
> > 
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > ---
> >  ffplay.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/ffplay.c b/ffplay.c
> > index 1544b9e..eee9da3 100644
> > --- a/ffplay.c
> > +++ b/ffplay.c
> > @@ -2730,7 +2730,7 @@ static int read_thread(void *arg)
> >          ic->pb->eof_reached = 0; // FIXME hack, ffplay maybe should not use url_feof() to test for the end
> >  
> >      if (seek_by_bytes < 0)
> > -        seek_by_bytes = !!(ic->iformat->flags & AVFMT_TS_DISCONT);
> > +        seek_by_bytes = !!(ic->iformat->flags & AVFMT_TS_DISCONT) && strcmp("ogg", ic->iformat->name);
> 
> Would it make sense to create a specific format property for this one?
> So we avoid more format-specific hacks.

I dont know

[....]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130331/0933e4d5/attachment.asc>