[FFmpeg-devel] [PATCH] extractplanes filter

[Paul B Mahol]

On 5/3/13, Nicolas George <nicolas.george at normalesup.org> wrote:
> Le tridi 13 floreal, an CCXXI, Paul B Mahol a ecrit :
>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
>> ---
>>  doc/filters.texi               |  38 +++++++
>>  libavfilter/Makefile           |   1 +
>>  libavfilter/allfilters.c       |   1 +
>>  libavfilter/vf_extractplanes.c | 220
>> +++++++++++++++++++++++++++++++++++++++++
>>  4 files changed, 260 insertions(+)
>>  create mode 100644 libavfilter/vf_extractplanes.c
>
> Very minor remark: The order of the functions seems a bit strange: init,
> query_formats, config_input, config_output, filter_frame would seem more
> logical since that is the order they will be called (uninit can go more or
> less anywhere, after init or at the very end).

init needs config_output, i dislike adding forward declarations.

If there is some policy about this I will follow it.

>
> Apart from that, this looks very good, thanks.
>
> Regards,
>
> --
>   Nicolas George
>