[FFmpeg-devel] [PATCH] AVFrame width/height are now useless exceptfor internal purposes.

[Don Moir]

----- Original Message ----- 
From: "Reimar Döffinger" <Reimar.Doeffinger at gmx.de>
To: <ffmpeg-devel at ffmpeg.org>
Sent: Sunday, May 05, 2013 3:36 AM
Subject: [FFmpeg-devel] [PATCH] AVFrame width/height are now useless exceptfor internal purposes.


> At least document this change, which for VP6 with cropping triggered
> a few sanity checks in MPlayer.
> ---
> doc/APIchanges    |    5 +++++
> libavutil/frame.h |    4 +++-
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/doc/APIchanges b/doc/APIchanges
> index 763ccf0..a6d3b72 100644
> --- a/doc/APIchanges
> +++ b/doc/APIchanges
> @@ -15,6 +15,11 @@ libavutil:     2012-10-22
>
> API changes, most recent first:
>
> +2013-??-?? - xxxxxxx - lavu ??.?.???
> +  AVFrame width and height no longer match AVCodecContext width and height.
> +  They contain now purely internal values that have no relevance to users,
> +  you should not use them for any purpose.
> +

Wonder if it would be appropriate if a flag could be set in AVFrame or AVCodecContext to indicate that a change in width, height, 
format, etc has changed.

Would save code everywhere from having the check the possible change of each element.

> 2013-04-19 - xxxxxxx - lavc 55.4.100
>   Add AV_CODEC_PROP_TEXT_SUB property for text based subtitles codec.
>
> diff --git a/libavutil/frame.h b/libavutil/frame.h
> index 39a664f..8b1112c 100644
> --- a/libavutil/frame.h
> +++ b/libavutil/frame.h
> @@ -117,7 +117,9 @@ typedef struct AVFrame {
>     uint8_t **extended_data;
>
>     /**
> -     * width and height of the video frame
> +     * allocated width and height of the video frame
> +     * these have nothing to do with the actual visible size of the
> +     * frame data, that information is not available
>      */
>     int width, height;
>
> -- 
> 1.7.10.4
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel