[FFmpeg-devel] [PATCH] lavfi: modify names of deshake_kernel.h and unsharp_kernel.h

Wei Gao highgod0401 at gmail.com
Wed May 8 02:58:16 CEST 2013


2013/5/8 Stefano Sabatini <stefasab at gmail.com>

> On date Wednesday 2013-05-08 01:04:13 +0200, Clément Bœsch encoded:
> > On Wed, May 08, 2013 at 12:56:34AM +0200, Stefano Sabatini wrote:
> > [...]
> > > > --- a/libavfilter/unsharp_kernel.h
> > > > +++ b/libavfilter/unsharp_opencl_kernel.h
> > > > @@ -134,4 +134,4 @@ kernel void unsharp(global  unsigned char *src,
> > > >
> > > >  );
> > > >
> > > > -#endif /* AVFILTER_UNSHARP_KERNEL_H */
> > > > +#endif /* AVFILTER_UNSHARP_OPENCL_KERNEL_H */
> > >
> > > same here.
> > >
> > > LGTM otherwise, thanks.
> >
> > Maybe it would be better to use a opencl_ prefix though (so files are
> > sticked together)
>
> Or alternatively put the files in a dedicated opencl dir (like we
> basically do for ASM). But I consider per-filter grouping better than
> per architecture grouping in this specific case, so I'd stick with
> this patch approach.
>
Hi, thanks for reviewing, the attachment is the patch.

Thanks
Best regards

> --
> FFmpeg = Fiendish & Fiendish Mean Picky Evanescent Gadget
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavfi-modify-names-of-deshake_kernel.h-and-unsharp_kernel.h.patch
Type: application/octet-stream
Size: 3385 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130508/2b5f2ab0/attachment.obj>


More information about the ffmpeg-devel mailing list