[FFmpeg-devel] [PATCH 2/5] fate: avoid framemd5, use framecrc its faster

[James Almer]

On 08/05/13 12:00 PM, Michael Niedermayer wrote:
> diff --git a/tests/fate-run.sh b/tests/fate-run.sh
> index 9f5690d..8d8e76c 100755
> --- a/tests/fate-run.sh
> +++ b/tests/fate-run.sh
> @@ -90,7 +90,7 @@ framecrc(){
>  }
>  
>  framemd5(){
> -    ffmpeg "$@" -f framemd5 -
> +    ffmpeg "$@" -f framecrc -
>  }

Wouldn't it make more sense to replace calls to framemd5() with calls to 
framecrc() on each fate test instead of doing this?
Same with md5() calling the new adler protocol in the fourth patch, and
md5.sh using the new ffadler tool. It would be nicer to add new a adler 
function and bash script and replace the needed calls with them.

Having md5 functions and tools doing adler calculations is very misleading.

Regards.