[FFmpeg-devel] [PATCH 1/5] lavfi: remplace passthrough_filter_frame with a flag.

[Clément Bœsch]

On Sat, May 11, 2013 at 05:17:48PM +0200, Michael Niedermayer wrote:
[...]
> > /**
> >  * Some filters support a generic "enable" expression option that can be used
> >  * to enable or disable a filter in the timeline. Filters supporting this
> >  * option have this flag set. When the enable expression is false, the
> >  * default no-op filter_frame() function is called in place of the
> >  * filter_frame() callback defined on each input pad, thus the frame
> >  * is passed unchanged to the next filters.
> >  */
> > #define AVFILTER_FLAG_SUPPORT_TIMELINE_DEFAULT   (1 << 16)
> > 
> > /**
> >  * Same as AVFILTER_FLAG_SUPPORT_TIMELINE_DEFAULT, except that the filter will have its
> >  * filter_frame() callback(s) called as usual even when the enable
> >  * expression is false. The filter will disable filtering
> >  * within the filter_frame() callback(s) itself, for example executing
> >  * code depending on the AVFilterContext->is_disabled value.
> >  */
> > #define AVFILTER_FLAG_SUPPORT_TIMELINE_INTERNAL     (1 << 17)
> 
> why do you need 2 flags ?
> 
> if enabled filter_frame() is called
> if disabled passthrough_filter_frame() is called
> 

passthrough_filter_frame() is deleted in that patch. We need to be able to
differentiate filter from filters with timeline from filters with internal
timeline.

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130511/73532efa/attachment.asc>