[FFmpeg-devel] [PATCH 1/5] lavfi: remplace passthrough_filter_frame with a flag.

[Clément Bœsch]

On Sun, May 12, 2013 at 12:11:04PM +0200, Stefano Sabatini wrote:
[...]
> Reminder: bump minor, update APIchanges.
> 

Done

> > +    /* the filter must select internal or default */
> 
> Nit: ... or default exclusively
> 

Fixed.

[...]
> > @@ -444,9 +431,25 @@ enum AVMediaType avfilter_pad_get_type(const AVFilterPad *pads, int pad_idx);
> >  /**
> >   * Some filters support a generic "enable" expression option that can be used
> >   * to enable or disable a filter in the timeline. Filters supporting this
> > - * option have this flag set.
> > + * option have this flag set. When the enable expression is false, the
> > + * default no-op filter_frame() function is called in place of the
> > + * filter_frame() callback defined on each input pad, thus the frame
> > + * is passed unchanged to the next filters.
> > + */
> > +#define AVFILTER_FLAG_SUPPORT_TIMELINE_DEFAULT  (1 << 16)
> 
> > +/**
> > + * Same as AVFILTER_FLAG_SUPPORT_TIMELINE_DEFAULT, except that the filter will have its
> > + * filter_frame() callback(s) called as usual even when the enable
> > + * expression is false. The filter will disable filtering
> > + * within the filter_frame() callback(s) itself, for example executing
> > + * code depending on the AVFilterContext->is_disabled value.
> 
> Nit: weird justification.
> 

Fixed.

> > + */
> > +#define AVFILTER_FLAG_SUPPORT_TIMELINE_INTERNAL (1 << 17)
> 
> Note:
> AVFILTER_FLAG_SUPPORT_TIMELINE_DEFAULT
> 
> I realize the "default" is a bit confusing.
> 
> Alternatively:
> AVFILTER_FLAG_SUPPORT_TIMELINE
> AVFILTER_FLAG_SUPPORT_TIMELINE_INTERNAL
> 
> or you can use GENERIC instead like in the first patch. I leave this
> up to you.
> 

Restored "GENERIC".

> [...]
> 
> LGTM otherwise.

Thank you, applied.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130512/84b691cd/attachment.asc>