[FFmpeg-devel] [PATCH 1/5] ra144: use scalarproduct_int16

[Michael Niedermayer]

On Fri, May 10, 2013 at 09:00:11PM +0200, Michael Niedermayer wrote:
> On Fri, May 10, 2013 at 11:39:04AM +0200, Christophe Gisquet wrote:
> > 2013/5/10 Christophe Gisquet <christophe.gisquet at gmail.com>:
> > > @@ -374,7 +376,7 @@ static void ra144_encode_subblock(RA144Context *ractx,
> > >          memcpy(cba, work + LPC_ORDER, sizeof(cba));
> > >
> > >          ff_copy_and_dup(cba_vect, ractx->adapt_cb, cba_idx + BLOCKSIZE / 2 - 1);
> > > -        m[0] = (ff_irms(cba_vect) * rms) >> 12;
> > > +        m[0] = (ff_irms(&ractx->dsp, cba_vect) * rms) >> 12;
> > >      }
> > >      fixed_cb_search(work + LPC_ORDER, coefs, data, cba_idx, &cb1_idx, &cb2_idx);
> > >      for (i = 0; i < BLOCKSIZE; i++) {
> > 
> > I think this hunk is wrong. What's the name of the fate test for encoding ra144?
> 
> fate-acodec-ra144 should do that
> 
> also you can find the names of tests by greping the output of
> make fate-list

and it seems you are correct, it breaks the test:

TEST    acodec-ra144
stddev: 6452.80 PSNR: 20.13 MAXDIFF:53031 bytes:    96000/    96000
Test acodec-ra144 failed. Look at tests/data/fate/acodec-ra144.err for details.
make: *** [fate-acodec-ra144] Error 1

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130514/46ada44c/attachment.asc>