[FFmpeg-devel] [PATCH] lavfi: factorize drawgrid and drawbox code

Andrey Utkin andrey.krieger.utkin at gmail.com
Tue May 14 23:34:40 CEST 2013


2013/5/14 Stefano Sabatini <stefasab at gmail.com>:
> -static const AVOption drawbox_options[] = {
> +static const AVOption options[] = {
>      { "x",      "Horizontal position of the left box edge", OFFSET(x),         AV_OPT_TYPE_INT,    { .i64 = 0 }, INT_MIN, INT_MAX, FLAGS },
>      { "y",      "Vertical position of the top box edge",    OFFSET(y),         AV_OPT_TYPE_INT,    { .i64 = 0 }, INT_MIN, INT_MAX, FLAGS },
>      { "width",  "Width of the box",                         OFFSET(w),         AV_OPT_TYPE_INT,    { .i64 = 0 }, 0,       INT_MAX, FLAGS },

Great.
Just options descriptions all mention "box". Everything could be fixed
by saying just "set width" etc., except x and y, which should be
described separately.

--
Andrey Utkin


More information about the ffmpeg-devel mailing list