[FFmpeg-devel] [PATCH] md5: avoid unnecessary memcpy.

[Reimar Döffinger]

On Fri, May 17, 2013 at 09:05:06PM +0200, Giorgio Vazzana wrote:
> 2013/5/17 Reimar Döffinger <Reimar.Doeffinger at gmx.de>:
> > Signed-off-by: Reimar Döffinger <Reimar.Doeffinger at gmx.de>
> > ---
> >  libavutil/md5.c |   34 +++++++++++++++++++++++++++-------
> >  1 file changed, 27 insertions(+), 7 deletions(-)
> >
> > diff --git a/libavutil/md5.c b/libavutil/md5.c
> > index f8f08f1..7375ce5 100644
> > --- a/libavutil/md5.c
> > +++ b/libavutil/md5.c
> > @@ -139,20 +139,40 @@ void av_md5_init(AVMD5 *ctx)
> >      ctx->ABCD[3] = 0x67452301;
> >  }
> >
> > -void av_md5_update(AVMD5 *ctx, const uint8_t *src, const int len)
> > +void av_md5_update(AVMD5 *ctx, const uint8_t *src, int len)
> 
> I think md5.h needs to be update too?

The compiler obviously doesn't care (and it does not make a difference
either from API not ABI side), but yes it's better to.

> LGTM

Thanks, pushed.