[FFmpeg-devel] ftp protocol support

[Michael Niedermayer]

On Thu, May 16, 2013 at 08:02:13PM +0200, Lukasz M wrote:
> 2013/5/16 Clément Bœsch <ubitux at gmail.com>:
> > On Thu, May 16, 2013 at 06:31:03PM +0200, Lukasz M wrote:
> >> > Did you look at the AVBPrint API? It might be relevant to use it
> >> > eventually.
> >>
> >> You mean to use ABVprint API inside functions where commands are
> >> currently created with snprintf?
> >
> > Yes that was the idea.
> >
> >> Will this change anything? I think it will be harder to maintain.
> >>
> >
> > It was an innocent question, not a request. It can makes sense if you're
> > dealing with ± large buffers and incrementally adding stuff to them. That
> > might not be the case in your code, so feel free to ignore.
> >
> 
> Updated patch in attachment. I skipped AVBPrintf remark.
> Regarding valgrind, yes, I tested and no leaks detected.
> 
> Best Regards,
> Lukasz Marek

>  Changelog                |    1 
>  MAINTAINERS              |    1 
>  configure                |    1 
>  doc/protocols.texi       |   34 ++
>  libavformat/Makefile     |    1 
>  libavformat/allformats.c |    1 
>  libavformat/ftp.c        |  659 +++++++++++++++++++++++++++++++++++++++++++++++
>  7 files changed, 698 insertions(+)
> bc89e36f69be66c2a4c23168fd19b86f13c96fc8  0001-FTP-protocol-support.patch
> From 9656b44defdce0f050a0f0be8be273d445cd069b Mon Sep 17 00:00:00 2001
> From: Lukasz Marek <lukasz.m.luki at gmail.com>
> Date: Wed, 15 May 2013 16:08:11 +0200
> Subject: [PATCH] FTP protocol support

patch applied

to maintain the code in the future it is probably easiest if you
setup a clone of ffmpeg git somewhere (like github) and ask me to
merge when you have some changes that you want in ffmpeg.org

Thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130518/49981ac3/attachment.asc>