[FFmpeg-devel] [PATCH] lavfi: simplify link dependencies.

[Clément Bœsch]

On Thu, May 23, 2013 at 02:12:26AM +0200, Michael Niedermayer wrote:
> On Wed, May 22, 2013 at 07:38:14PM +0200, Clément Bœsch wrote:
> > This avoids re-declaring the filter dependencies. Also, it fixes the
> > optional dependencies: for instance the select filter having an optional
> > dependency on avcodec.
> > ---
> >  libavfilter/Makefile | 23 ++++++-----------------
> >  1 file changed, 6 insertions(+), 17 deletions(-)
> > 
> > diff --git a/libavfilter/Makefile b/libavfilter/Makefile
> > index 6cc2930..2897f49 100644
> > --- a/libavfilter/Makefile
> > +++ b/libavfilter/Makefile
> > @@ -2,23 +2,12 @@ include $(SUBDIR)../config.mak
> >  
> >  NAME = avfilter
> >  FFLIBS = avutil
> > -FFLIBS-$(CONFIG_ACONVERT_FILTER)             += swresample
> > -FFLIBS-$(CONFIG_AMOVIE_FILTER)               += avformat avcodec
> > -FFLIBS-$(CONFIG_ARESAMPLE_FILTER)            += swresample
> > -FFLIBS-$(CONFIG_ASYNCTS_FILTER)              += avresample
> > -FFLIBS-$(CONFIG_ATEMPO_FILTER)               += avcodec
> > -FFLIBS-$(CONFIG_DECIMATE_FILTER)             += avcodec
> > -FFLIBS-$(CONFIG_DESHAKE_FILTER)              += avcodec
> > -FFLIBS-$(CONFIG_MOVIE_FILTER)                += avformat avcodec
> > -FFLIBS-$(CONFIG_MP_FILTER)                   += avcodec
> > -FFLIBS-$(CONFIG_PAN_FILTER)                  += swresample
> > -FFLIBS-$(CONFIG_PP_FILTER)                   += postproc
> > -FFLIBS-$(CONFIG_REMOVELOGO_FILTER)           += avformat avcodec swscale
> > -FFLIBS-$(CONFIG_RESAMPLE_FILTER)             += avresample
> > -FFLIBS-$(CONFIG_SCALE_FILTER)                += swscale
> > -FFLIBS-$(CONFIG_SHOWSPECTRUM_FILTER)         += avcodec
> > -FFLIBS-$(CONFIG_SMARTBLUR_FILTER)            += swscale
> > -FFLIBS-$(CONFIG_SUBTITLES_FILTER)            += avformat avcodec
> > +FFLIBS-$(CONFIG_AVCODEC)    += avcodec
> > +FFLIBS-$(CONFIG_AVFORMAT)   += avformat
> > +FFLIBS-$(CONFIG_AVRESAMPLE) += avresample
> > +FFLIBS-$(CONFIG_POSTPROC)   += postproc
> > +FFLIBS-$(CONFIG_SWRESAMPLE) += swresample
> > +FFLIBS-$(CONFIG_SWSCALE)    += swscale
> 
> I think with that change libavfilter would depend on all build libs
> even if it uses nothing from them
> 

Yes, it will make a dependency, but only if it's available. What problem
could that cause? I mean, in what situation would you not want that
dependency if you build the other libraries?

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130523/82e2de68/attachment.asc>