[FFmpeg-devel] [PATCH 1/4] lavfi/bbox: use inlink->frame_count

Stefano Sabatini stefasab at gmail.com
Sun May 26 13:35:41 CEST 2013


On date Sunday 2013-05-26 10:00:55 +0000, Paul B Mahol encoded:
> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> ---
>  libavfilter/vf_bbox.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/libavfilter/vf_bbox.c b/libavfilter/vf_bbox.c
> index 6b4cdd0..db73f01 100644
> --- a/libavfilter/vf_bbox.c
> +++ b/libavfilter/vf_bbox.c
> @@ -30,7 +30,7 @@
>  #include "internal.h"
>  
>  typedef struct {
> -    unsigned int frame;
> +    int unused;
>  } BBoxContext;

You could just remove it?

>  
>  static int query_formats(AVFilterContext *ctx)
> @@ -63,7 +63,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame)
>      h = box.y2 - box.y1 + 1;
>  
>      av_log(ctx, AV_LOG_INFO,
> -           "n:%d pts:%s pts_time:%s", bbox->frame,
> +           "n:%"PRId64" pts:%s pts_time:%s", inlink->frame_count,
>             av_ts2str(frame->pts), av_ts2timestr(frame->pts, &inlink->time_base));
>  
>      if (has_bbox) {
> @@ -76,7 +76,6 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame)
>      }
>      av_log(ctx, AV_LOG_INFO, "\n");
>  
> -    bbox->frame++;
>      return ff_filter_frame(inlink->dst->outputs[0], frame);
>  }

LGTM, thanks.
-- 
FFmpeg = Free and Fiendish Minimal Ponderous Erudite Guru


More information about the ffmpeg-devel mailing list