[FFmpeg-devel] [PATCH] Add additional FFV1 fate tests

[Michael Niedermayer]

On Wed, Nov 06, 2013 at 02:48:23PM +0100, Peter B. wrote:
> On 11/05/2013 01:42 PM, Michael Niedermayer wrote:
> > tiny_psnr is run here (and in some other cases) with the wrong
> > parameters
> > (tiny seems using 16bit) but the raw video is 8bit
> 
> Ok. Which should I use here instead?

for 8bit samples tiny should do 8bit compares
for >8bit it should use 16bit (as >8bit are stored in 16bit)


> I'll try to figure out where to configure/adjust this.
> 
> 
> > except that, the testset looks impresive
> 
> Thanks.
> I'm still having some questions regarding the results of LCOV, though.
> There are some lines of the code, which are not executed by my testset,
> although I think they should be.
> For example:
> 
> (libavcodec/ffv1enc.c):
> Lines 849-922: Looks like 2pass-related, but LCOV says it's not executed
> in my 2pass tests

the first question is, is the code really not executed
(the coverage stuff can give wrong results with optimizations)


> 
> (libavcodec/ffv1dec.c):
> Lines 322-327: Looks like handling field-order in slices, but only the
> case for progressive is executed.
> 
> 
> Am I interpreting the code wrong, or are my tests for these cases incorrect?
> 
> 
> Regards,
> Pb
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131106/f37695e1/attachment.asc>