[FFmpeg-devel] [PATCH] Add additional FFV1 fate tests

[Reimar Döffinger]

On Wed, Nov 06, 2013 at 10:48:48PM +0100, Reimar Döffinger wrote:
> On Tue, Nov 05, 2013 at 02:14:08AM +0100, Peter B. wrote:
> > +# Multipass:
> > +fate-ffv1-enc-v3-yuv422p_pass1:  ENCOPTS = -level 3 -an -pix_fmt yuv422p -pass 1 -passlogfile $(DEC_SRC)/ffv1-multipass $(FLAGS_FFV1_V3)
> > +
> > +fate-ffv1-enc-v3-yuv422p_pass2:  ${ENCOPTS = -level 3 -pix_fmt yuv422p -pass 2 -passlogfile $(DEC_SRC)/ffv1-multipass $(FLAGS_FFV1_V3)} fate-ffv1-enc-v3-yuv422p_pass1
> 
> > +# Multipass:
> > +fate-ffv1-dec-v3-yuv422p_pass1:  ${CMD = framecrc -i $(DEC_SRC)/ffv1-enc-v3-yuv422p_pass1.avi} fate-ffv1-enc-v3-yuv422p_pass1
> > +fate-ffv1-dec-v3-yuv422p_pass2:  $(CMD = framecrc -i $(DEC_SRC)/ffv1-enc-v3-yuv422p_pass2.avi) fate-ffv1-enc-v3-yuv422p_pass2
> 
> Hm, why is this $( and all others are ${ ?
> And why does the pass2 encode not use -an but pass1 does?
> Not sure any of these is an issue, just trying to double-check what
> might cause the lack of coverage for pass 2,,,

Also, not sure it will work, but I think slightly more make-like would be
to specify the $(DEC_SRC)/ffv1-multipass as an actual dependency, e.g.
(if I remember the syntax right)
fate-ffv1-enc-v3-yuv422p_pass1 $(DEC_SRC)/ffv1-multipass:  ENCOPTS = -level 3 -an -pix_fmt yuv422p -pass 1 -passlogfile $(DEC_SRC)/ffv1-multipass $(FLAGS_FFV1_V3)
fate-ffv1-enc-v3-yuv422p_pass2:  ${ENCOPTS = -level 3 -pix_fmt yuv422p -pass 2 -passlogfile $(DEC_SRC)/ffv1-multipass $(FLAGS_FFV1_V3)} $(DEC_SRC)/ffv1-multipass

However I admit this might go wrong if $(DEC_SRC)/ffv1-multipass somehow
already exists, so it might be better to keep it less make-like, not
sure.
When is that file cleaned up/removed?
Also, might there be a point in somehow check-summing or otherwise
comparing the multipass log-file to some reference?