[FFmpeg-devel] lavf/matroska*: DiscardPadding is a signed integer

[Michael Niedermayer]

On Fri, Nov 15, 2013 at 11:12:05PM +0100, Jan Gerber wrote:
> On 11/15/2013 09:51 PM, Michael Niedermayer wrote:
> > On Thu, Nov 14, 2013 at 12:58:28PM +0100, Jan Gerber wrote:
> >>
> >> according to the Matriska Specification
> >>  http://matroska.org/technical/specs/index.html
> >> DiscardPadding is a signed integer.
> > 
> > has this been tested against other (de)muxers ?
> > its the first code that uses sint_* so having it double checked makes
> > sense, to ensure we dont generate invalid files
> 
> Afaik the only use of DiscardPadding right now is with Opus (still
> -strict -2) - and Opus only uses it for end trimming so will never use
> negative values.
> 
> To test negative values I modified libavformat/matroskaenc.c:1399 to
> always write a negative value. The value in the resulting file is parsed
> correctly if inspected with mkvinfo and with a test program using
> libnestegg (part of firefox). Positive values are also correct.

thanks

patch applied


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131116/e01ba12c/attachment.asc>