[FFmpeg-devel] [PATCH] lavf: Exporting opus pre_skip in AVCodecContext

Michael Niedermayer michaelni at gmx.at
Mon Nov 25 02:06:01 CET 2013


On Sat, Nov 23, 2013 at 05:22:15PM +0100, Nicolas George wrote:
> Le primidi 1er frimaire, an CCXXII, Vignesh Venkatasubramanian a écrit :
> > Opus Pre Skip is exported in AVCodecContext->delay similar to how
> > it is done for matroska. Doing the same for ogg too.
> > 
> > Signed-off-by: Vignesh Venkatasubramanian <vigneshv at google.com>
> > ---
> >  libavformat/oggparseopus.c | 1 +
> >  1 file changed, 1 insertion(+)
> 
> Probably ok.

should i apply it or wait ?


> 
> But I am a bit confused about the whole feature: I thought that lavc was now
> dropping the padding samples: in that case, codec->delay should not be set,
> either in Ogg or in Matroska. On the other hand, a quick test shows the
> skipped samples still there, this is strange.
> 
> Regards,
> 
> -- 
>   Nicolas George



> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131125/d054643c/attachment.asc>


More information about the ffmpeg-devel mailing list