[FFmpeg-devel] [PATCH 2/2] ffmpeg: add max_error_rate to allow tuning the point decoding errors are considered a failure of the whole transcoding.

[Michael Niedermayer]

On Tue, Oct 01, 2013 at 05:34:16PM +0100, Derek Buitenhuis wrote:
> On Tue, Oct 1, 2013 at 5:28 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > -    if (2*decode_error_stat[0] < decode_error_stat[1])
> > +    if (decode_error_stat[1] && (decode_error_stat[0] + decode_error_stat[1]) * max_error_rate <= decode_error_stat[1])
> >          exit_program(69);
> 
> Shouldn't this be changed to 1, since after this patch, we consider it
> an error (as per the user's settings)?

my thought was to use distinct error codes to allow a user to
identify why a error happened but iam fine with anything that
people prefer ...

btw 69 == 'E' which i thought nicely represents "too many Errors"


> 
> > @@ -2709,6 +2710,8 @@ const OptionDef options[] = {
> >          "extract an attachment into a file", "filename" },
> >      { "debug_ts",       OPT_BOOL | OPT_EXPERT,                       { &debug_ts },
> >          "print timestamp debugging info" },
> > +    { "max_error_rate",  HAS_ARG | OPT_FLOAT,                        { &max_error_rate },
> > +        "maximum error rate", "rate between 0.0 and 1.1" },
> 
> What does this range represent? Should be added to the message.

fixed
-        "maximum error rate", "rate between 0.0 and 1.1" },
+        "maximum error rate", "ratio of errors from 0.0 to 1.1 above which ffmpeg returns an error instead of 0." },

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Avoid a single point of failure, be that a person or equipment.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131001/7892d872/attachment.asc>