[FFmpeg-devel] [PATCH] Native VP9 decoder.

[Ronald S. Bultje]

Hi,

On Wed, Oct 2, 2013 at 6:53 AM, Michael Niedermayer <michaelni at gmx.at>wrote:

> On Tue, Oct 01, 2013 at 08:36:39PM -0400, Ronald S. Bultje wrote:
> > Hi,
> >
> > On Tue, Oct 1, 2013 at 2:31 PM, Michael Niedermayer <michaelni at gmx.at
> >wrote:
> >
> > > On Mon, Sep 30, 2013 at 11:03:17PM -0400, Ronald S. Bultje wrote:
> > > > Hi,
> > > >
> > > > On Mon, Sep 30, 2013 at 8:15 AM, Derek Buitenhuis <
> > > > derek.buitenhuis at gmail.com> wrote:
> > > [...]
> > >
> > > > > > +static int vp9_decode_packet(AVCodecContext *avctx, void
> *out_pic,
> > > > > > +                             int *got_frame, AVPacket *avpkt)
> > > > > > +{
> > > > >
> > > > > [...]
> > > > >
> > > > > > +    // read superframe index - this is a collection of
> individual
> > > > > frames that
> > > > > > +    // together lead to one visible frame
> > > > > > +    if (size <= 0)
> > > > > > +        return AVERROR_INVALIDDATA;
> > > > >
> > > > > Is it not guaranteed to have a non-zero packet?
> > > > >
> > > >
> > > > Not sure, Michael?
> > >
> > > without CODEC_CAP_DELAY 0 sized packets are currently not passed to
> > > the decoder.
> > > I dont know if that will always be true in the future
> > >
> >
> > OK changed locally into an av_assert1. I'll push to my github repository,
> > no need for a new patch on NL at this point I think.
>
> did you forget to "git add" some files ?
>
>
> TEST    vp9-emu-edge-00-quantizer-07
> reference file './tests/ref/fate/vp9-segmentation-akiyo' not found
> ./tests/fate-run.sh: 242: ./tests/fate-run.sh: cannot open
> tests/data/fate/vp9-segmentation-akiyo.diff: No such file
> Test vp9-segmentation-akiyo failed. Look at
> tests/data/fate/vp9-segmentation-akiyo.err for details.
> make: *** [fate-vp9-segmentation-akiyo] Error 1
>
> reference file './tests/ref/fate/vp9-tiling-pedestrian' not found
> ./tests/fate-run.sh: 242: ./tests/fate-run.sh: cannot open
> tests/data/fate/vp9-tiling-pedestrian.diff: No such file
> Test vp9-tiling-pedestrian failed. Look at
> tests/data/fate/vp9-tiling-pedestrian.err for details.
> make: *** [fate-vp9-tiling-pedestrian] Error 1
>
> reference file './tests/ref/fate/vp9-segmentation-akiyo' not found
> ./tests/fate-run.sh: 242: ./tests/fate-run.sh: cannot open
> tests/data/fate/vp9-emu-edge-segmentation-akiyo.diff: No such file
> Test vp9-emu-edge-segmentation-akiyo failed. Look at
> tests/data/fate/vp9-emu-edge-segmentation-akiyo.err for details.
> make: *** [fate-vp9-emu-edge-segmentation-akiyo] Error 1
>
> reference file './tests/ref/fate/vp9-tiling-pedestrian' not found
> ./tests/fate-run.sh: 242: ./tests/fate-run.sh: cannot open
> tests/data/fate/vp9-emu-edge-tiling-pedestrian.diff: No such file
> Test vp9-emu-edge-tiling-pedestrian failed. Look at
> tests/data/fate/vp9-emu-edge-tiling-pedestrian.err for details.
> make: *** [fate-vp9-emu-edge-tiling-pedestrian] Error 1
>

Right, fixed on github (master branch), you should be able to
re-cherry-pick from there.

Ronald