[FFmpeg-devel] [Bulk] Re: [PATCH] swscale/options: switch default to bicubic

[Tim Nicholson]

On 30/09/13 21:57, wm4 wrote:
> On Mon, 30 Sep 2013 22:20:07 +0200
> Michael Niedermayer <michaelni at gmx.at> wrote:
> 
>> Suggested-by: Ronald S. Bultje
>> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
>> ---
>>  libswscale/options.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libswscale/options.c b/libswscale/options.c
>> index 2b3147b..9e8703f 100644
>> --- a/libswscale/options.c
>> +++ b/libswscale/options.c
>> @@ -34,7 +34,7 @@ static const char *sws_context_to_name(void *ptr)
>>  #define VE AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_ENCODING_PARAM
>>  
>>  static const AVOption swscale_options[] = {
>> -    { "sws_flags",       "scaler flags",                  OFFSET(flags),     AV_OPT_TYPE_FLAGS,  { .i64  = SWS_BILINEAR       }, 0,       UINT_MAX,       VE, "sws_flags" },
>> +    { "sws_flags",       "scaler flags",                  OFFSET(flags),     AV_OPT_TYPE_FLAGS,  { .i64  = SWS_BICUBIC        }, 0,      UINT_MAX,        VE, "sws_flags" },
>>      { "fast_bilinear",   "fast bilinear",                 0,                 AV_OPT_TYPE_CONST,  { .i64  = SWS_FAST_BILINEAR  }, INT_MIN, INT_MAX,        VE, "sws_flags" },
>>      { "bilinear",        "bilinear",                      0,                 AV_OPT_TYPE_CONST,  { .i64  = SWS_BILINEAR       }, INT_MIN, INT_MAX,        VE, "sws_flags" },
>>      { "bicubic",         "bicubic",                       0,                 AV_OPT_TYPE_CONST,  { .i64  = SWS_BICUBIC        }, INT_MIN, INT_MAX,        VE, "sws_flags" },
> 

+1

> Then maybe also switch vf_scale.c's default to bicubic. It'd be slightly
> confusing if these defaults are be different.

+1 if this is indeed would be the case.

> [..]
-- 
Tim