[FFmpeg-devel] [PATCH 2/2] ffmpeg: add max_error_rate to allow tuning the point decoding errors are considered a failure of the whole transcoding.
Paul B Mahol
onemda at gmail.com
Tue Oct 8 11:58:31 CEST 2013
On 10/7/13, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Thu, Oct 03, 2013 at 04:08:35PM +0200, Michael Niedermayer wrote:
>> On Thu, Oct 03, 2013 at 01:24:52PM +0100, Derek Buitenhuis wrote:
>> > On 10/1/2013 5:45 PM, Michael Niedermayer wrote:
>> > >> Shouldn't this be changed to 1, since after this patch, we consider
>> > >> it
>> > >> an error (as per the user's settings)?
>> > >
>> > > my thought was to use distinct error codes to allow a user to
>> > > identify why a error happened but iam fine with anything that
>> > > people prefer ...
>> >
>> > Non-standard (not 1 or 0) exit codes make using ffmpeg pragmatically
>> > quite
>> > a pain.
>> >
>> > >>> @@ -2709,6 +2710,8 @@ const OptionDef options[] = {
>> > >>> "extract an attachment into a file", "filename" },
>> > >>> { "debug_ts", OPT_BOOL | OPT_EXPERT,
>> > >>> { &debug_ts },
>> > >>> "print timestamp debugging info" },
>> > >>> + { "max_error_rate", HAS_ARG | OPT_FLOAT,
>> > >>> { &max_error_rate },
>> > >>> + "maximum error rate", "rate between 0.0 and 1.1" },
>> > >>
>> > >> What does this range represent? Should be added to the message.
>> > >
>> > > fixed
>> > > - "maximum error rate", "rate between 0.0 and 1.1" },
>> > > + "maximum error rate", "ratio of errors from 0.0 to 1.1 above
>> > > which ffmpeg returns an error instead of 0." },
>> >
>> > ... so what ARE 0.0 and 1.1? 1.1 errors per second? 1.1 errors? 1.1
>> > magic pixies?
>>
>> the idea was that 0 means 0% and 1 means 100% where 1 would still
>> accept cases that had 1 successfully decoded frame and above 1 would
>> accept even 0 successfully decoded frames
>>
>> but ive simplified it so it doesnt need >1 values
>>
>> commit 43221418e4f0ae970ab4b05fe99ee7099d84a89c
>> Author: Michael Niedermayer <michaelni at gmx.at>
>> Date: Tue Oct 1 18:17:16 2013 +0200
>>
>> ffmpeg: add max_error_rate to allow tuning the point decoding errors
>> are considered a failure of the whole transcoding.
>>
>> Suggested-by: Daemon404
>> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
>
> applied
What about mentioning this in changelog?
More information about the ffmpeg-devel
mailing list