[FFmpeg-devel] [PATCH 2/3] avformat/gif: fix final_delay unit in documentation.

[Michael Niedermayer]

On Sat, Oct 19, 2013 at 08:47:49PM +0200, Clément Bœsch wrote:
> ---
>  libavformat/gif.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/gif.c b/libavformat/gif.c
> index cc8ae50..b55d5c9 100644
> --- a/libavformat/gif.c
> +++ b/libavformat/gif.c
> @@ -211,7 +211,7 @@ static int gif_write_trailer(AVFormatContext *s)
>  static const AVOption options[] = {
>      { "loop", "Number of times to loop the output: -1 - no loop, 0 - infinite loop", OFFSET(loop),
>        AV_OPT_TYPE_INT, { .i64 = 0 }, -1, 65535, ENC },
> -    { "final_delay", "Force delay (in ms) after the last frame", OFFSET(last_delay),
> +    { "final_delay", "Force delay (in centiseconds) after the last frame", OFFSET(last_delay),
>        AV_OPT_TYPE_INT, { .i64 = -1 }, -1, 65535, ENC },
>      { NULL },
>  };

LGTM

for future parameters i suggest to use seconds for all fields of
durations. That way users dont need to remember which unit which
duration or timeout field uses, and can just use the appropriate
suffix to get milli.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131021/ca84a5d9/attachment.asc>