[FFmpeg-devel] [PATCH] avcodec/metasound_data: Fix inconsistency in tables

[Michael Niedermayer]

On Wed, Oct 23, 2013 at 12:31:37PM +0200, Michael Niedermayer wrote:
> On Wed, Oct 23, 2013 at 08:03:36AM +0000, Paul B Mahol wrote:
> > On 10/22/13, Michael Niedermayer <michaelni at gmx.at> wrote:
> > > Fixes out of array read
> > 
> > How and why this fixes out of array read?
> 
> fcb16m has 320 elements but the code before the patch can address a
> table of 384 elements in its place.
> I dont know if theres some elements missing, or its maybe the wrong
> table, or if this patch is the correct fix, or if theres something
> else wrong
> which is why ive posted it here ... hoping someone reading this has
> easy access to some reference. (binary with the tables in it, spec,
> whatever)

instead of changing 24 to 20 one could change
-{ 2, bark_tab_m16_512,  24, fcb16m, 2, 5, cb1616m0, cb1616m1, 15 },
+{ 2, bark_tab_m16_512,  24,fcb44sm, 2, 5, cb1616m0, cb1616m1, 15 },

for example

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131023/2f534699/attachment.asc>